I have a vague recollection of having seen intellij warnings that really _shouldn't_ be "fixed". Unfortunately I'm not sure I'll be able to recall exactly what, but I thought I'd mention it as a word of caution, and in case it spurs anyone else's curiosity. Splitting any such PRs up by warning type would definitely be beneficial.
On Fri, May 27, 2022 at 11:24 AM Eric Pugh <ep...@opensourceconnections.com> wrote: > > Also, I guess I need to be careful to run spotless after I make changes to > the tests per package. > > On May 27, 2022, at 10:58 AM, Eric Pugh <ep...@opensourceconnections.com> > wrote: > > Here is what I did the other night: > > https://github.com/apache/solr/compare/main...epugh:intellij_suggested_fixes > > I could just work on package by package, pushing them up, and if there is > debate, I can just revert a commit on a package by package basis?? > > Thoughts? > > Eric > > > On May 27, 2022, at 10:29 AM, Mike Drob <md...@mdrob.com> wrote: > > I would try to handle them in several small PRs either grouped by module or > by warning type. > > On Fri, May 27, 2022 at 9:24 AM Eric Pugh <ep...@opensourceconnections.com> > wrote: >> >> Hey all, was poking around at a unit test while watching TV and noticed lots >> of warnings from IntelliJ, little stuff like exceptions being thrown that >> don’t need to be thrown, unused variables, or typos. >> >> I was thinking about going through and fixing those, just to get the long >> list of problems down…. Is this best handled with a single PR with a JIRA >> issue? Say a JIRA issue like “Clean up IntelliJ warnings for Test Code”? >> >> Eric >> >> >> >> _______________________ >> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | >> http://www.opensourceconnections.com | My Free/Busy >> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed >> This e-mail and all contents, including attachments, is considered to be >> Company Confidential unless explicitly stated otherwise, regardless of >> whether attachments are marked as such. >> > > _______________________ > Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | > http://www.opensourceconnections.com | My Free/Busy > Co-Author: Apache Solr Enterprise Search Server, 3rd Ed > This e-mail and all contents, including attachments, is considered to be > Company Confidential unless explicitly stated otherwise, regardless of > whether attachments are marked as such. > > > _______________________ > Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | > http://www.opensourceconnections.com | My Free/Busy > Co-Author: Apache Solr Enterprise Search Server, 3rd Ed > This e-mail and all contents, including attachments, is considered to be > Company Confidential unless explicitly stated otherwise, regardless of > whether attachments are marked as such. > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org For additional commands, e-mail: dev-h...@solr.apache.org
