Yep that was done to pass the XT tests for a release. Joe can you look at those returns again?
That advice from perlcritic needs to be taken with a large grain of salt.
In the past I have been bitten by this several times. It is generally safer to leave 'return undef' unless one carefully analyzes in what context a subroutine is being called. I'd suggest to revert that changeset entirely. Mark
