Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1326#discussion_r59214896
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/internal/CountStatAndMetric.java ---
@@ -197,12 +196,6 @@ long readApproximateTime(long value, long timeSpent,
long[] bucketTime, long[] b
return total;
}
- public void close() {
- if (_task != null) {
- _task.cancel();
--- End diff --
If we don't cancel it we leak memory and other things in the tests. We at
least need to close the stat when we are all done, not after calling
render-stats.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
