Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1326#discussion_r59215430
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/internal/CountStatAndMetric.java ---
@@ -197,12 +196,6 @@ long readApproximateTime(long value, long timeSpent,
long[] bucketTime, long[] b
return total;
}
- public void close() {
- if (_task != null) {
- _task.cancel();
--- End diff --
@revans2 - As far as I could see, close is being called only in the
render-stats. Tests initialize with negative number of buckets so _task is
never initialized at all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
