Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1326#discussion_r59215960
--- Diff: storm-core/src/clj/org/apache/storm/stats.clj ---
@@ -188,14 +168,12 @@
(defn value-bolt-stats!
[^BoltExecutorStats stats]
- (cleanup-bolt-stats! stats)
(merge (value-common-stats (:common stats))
(value-stats stats BOLT-FIELDS)
{:type :bolt}))
(defn value-spout-stats!
[^SpoutExecutorStats stats]
- (cleanup-spout-stats! stats)
--- End diff --
Really the issue is just that cleanup-bolt-stats! and cleanup-spout-stats!
needs to move from value-*-stats! to something that is called from the executor
shutdown.
https://github.com/abhishekagarwal87/storm/blob/STORM-1693/storm-core/src/clj/org/apache/storm/daemon/executor.clj#L409-L417
I thought that is where they were called from when I saw them, but I
obviously was wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
