Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1326#discussion_r59216981
--- Diff: storm-core/src/clj/org/apache/storm/stats.clj ---
@@ -188,14 +168,12 @@
(defn value-bolt-stats!
[^BoltExecutorStats stats]
- (cleanup-bolt-stats! stats)
(merge (value-common-stats (:common stats))
(value-stats stats BOLT-FIELDS)
{:type :bolt}))
(defn value-spout-stats!
[^SpoutExecutorStats stats]
- (cleanup-spout-stats! stats)
--- End diff --
Thanks @revans2 . Cancelling the task during the executor shutdown makes
sense. I will modify the PR accordingly and restore the close functions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
