Github user erikdw commented on the pull request:
https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22098737
In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java:
In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java on
line 66:
@vinodkc : whoa! I'm surprised that there are vendor-specific things
built-into the plugin. I should have google'ed around and seen if this was an
existing thing (I'll use the excuse that the key "configLocation" is
misleading). Thanks for explaining. BTW, that naming they used
(`<vendor>_checks.xml`) is not ideal if these only apply for checkstyle.
Do you happen to know if it's possible to override specific rules? Ah, I
searched, and it's not yet:
* https://github.com/checkstyle/checkstyle/issues/2873
I'm running an analysis of the checkstyle-result.xml files. I'll report
back with the situation regarding violations of the default 2-space indent
level, as compared to what it would be if we changed to 4-space. I'm also
going to analyze the line-length violations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
