Github user erikdw commented on the pull request:
https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22100422
In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java:
In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java on
line 66:
I'm about to fall asleep, so don't have time to post all info. I'm gonna
file a JIRA ticket related to tweaking checkstyle and then capture the stuff
I've been doing in that.
The long-and-short is that I believe we'll have way less failures overall
if we change to 4-space indents, *assuming* we exclude the generated thrift
code, which is 2-space indented. The storm-sql code is also 2-space indented.
But most other code is 4-space indented. Ignoring storm-client and storm-sql,
in all the rest of the code there are "only" **9001** violations if we use
4-space indent, versus **41818** if we go to 4-space indent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
