Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2363#discussion_r145322043
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/SupervisorUtils.java
---
@@ -69,11 +69,22 @@ public static void rmrAsUser(Map<String, Object> conf,
String id, String path) t
* @param blobInfo
* @return
*/
- public static Boolean shouldUncompressBlob(Map<String, Object>
blobInfo) {
+ public static boolean shouldUncompressBlob(Map<String, Object>
blobInfo) {
return ObjectReader.getBoolean(blobInfo.get("uncompress"), false);
}
/**
+ * Given the blob information returns the value of the workerRestart
field, handling it either being a string or a boolean value, or
+ * if it's not specified then returns false
+ *
+ * @param blobInfo
+ * @return
+ */
+ public static boolean needsCallback(Map<String, Object> blobInfo) {
--- End diff --
More detailed name would be better, like `blobNeedsWorkerRestart` or
`isBlobRequiredWorkerRestart`, or so on. From method name I can't see which
action this is about to do. Callback is too general.
---
