Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2363#discussion_r145321214
--- Diff: storm-client/src/jvm/org/apache/storm/utils/NimbusClient.java ---
@@ -86,7 +86,18 @@ public static NimbusClient
getConfiguredClient(Map<String, Object> conf) {
public static NimbusClient getConfiguredClient(Map<String, Object>
conf, Integer timeout) {
return getConfiguredClientAs(conf, null, timeout);
}
-
+
+ private static String oldLeader = "";
+
+ private static synchronized boolean shouldLogLeader(String leader) {
--- End diff --
Just 2 cents, I know the class field is only for this class method, but the
class method name doesn't give impression of side effect. Maybe better to
rename this to reflect its purpose better, like `updateLeaderNimbus` or so.
---
