Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2363#discussion_r145294329
--- Diff: storm-client/src/jvm/org/apache/storm/utils/NimbusClient.java ---
@@ -126,7 +137,9 @@ public static NimbusClient
getConfiguredClientAs(Map<String, Object> conf, Strin
nimbusSummary = client.getClient().getLeader();
if (nimbusSummary != null) {
String leaderNimbus = nimbusSummary.get_host() + ":" +
nimbusSummary.get_port();
- LOG.info("Found leader nimbus : {}", leaderNimbus);
+ if (LOG.isDebugEnabled() ||
shouldLogLeader(leaderNimbus)) {
--- End diff --
nit: There's mismatch between checked log level and actual log level of
message. I think `shouldLogLeader` will reduce verbose of message so personally
I prefer to leave message whenever shouldLogLeader is true.
---
