Github user hmcl commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2453#discussion_r156234691
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
 ---
    @@ -625,4 +619,15 @@ public String toString() {
         private String getTopicsString() {
             return kafkaSpoutConfig.getSubscription().getTopicsString();
         }
    +    
    +    private static class PollingInfo {
    --- End diff --
    
    I would rename it to **PollInfo** and I would add the following method
    
    ```java
    boolean isPollable() { return pollablePartitions.isEmpty(); }
    ```


---

Reply via email to