Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2453#discussion_r156508891
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -257,23 +258,24 @@ private void throwKafkaConsumerInterruptedException()
{
throw new RuntimeException(new InterruptedException("Kafka
consumer was interrupted"));
}
- private boolean commit() {
+ private boolean isCommitAllowed() {
return isAtLeastOnceProcessing() &&
commitTimer.isExpiredResetOnTrue(); // timer != null for non auto commit mode
}
-
- private Set<TopicPartition> poll() {
- final int maxUncommittedOffsets =
kafkaSpoutConfig.getMaxUncommittedOffsets();
-
+
+ private PollablePartitionInfo getPollablePartitionInfo() {
--- End diff --
Will rename
---
