Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2453#discussion_r156470144
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -230,14 +230,14 @@ public void nextTuple() {
kafkaSpoutConfig.getSubscription().refreshAssignment();
}
- if (commit()) {
+ if (isCommitAllowed()) {
--- End diff --
I guess you say allowed because of `isAtLeastOnceProcessing() && ...` ?
Other ideas would be
isReadyToCommit / isCommitReady / isCommittable ?
Because for atLeastOnceProcessing() the commits are always allowed if
ready, right?
---
