Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2453#discussion_r156455782
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -625,4 +619,15 @@ public String toString() {
private String getTopicsString() {
return kafkaSpoutConfig.getSubscription().getTopicsString();
}
+
+ private static class PollingInfo {
+ private final Set<TopicPartition> pollablePartitions;
+ private final Map<TopicPartition, Long>
pollableEarliestRetriableOffsets;
--- End diff --
OK, the name is fine after understanding it better. Can you put a line
comment saying what is in this var. Thanks.
---
