Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2453#discussion_r156518312
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -230,14 +230,14 @@ public void nextTuple() {
kafkaSpoutConfig.getSubscription().refreshAssignment();
}
- if (commit()) {
+ if (isCommitAllowed()) {
--- End diff --
That would work. However, I would say that most conventions suggest that
booleans methods should be of the for isPredicate. Of course there are variants
such as hasPredicate, shouldPredicate, mustPredicate.
When I suggested is* names above was with the intent of saying exactly
should commit, but starting with is. Up to you what to pick, and I am +1 after
that.
---
