[GitHub] storm pull request #2465: STORM-2844: KafkaSpout Throws IllegalStateExceptio...

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2465#discussion_r157346877
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
 ---
    @@ -225,6 +237,23 @@ private long doSeek(TopicPartition tp, 
OffsetAndMetadata committedOffset) {
             }
         }
     
    +    /**
    +     * Checks If {@link OffsetAndMetadata} was committed by this topology, 
either by this or another spout instance.
    --- End diff --
    
    Also we might want to add notes to EARLIEST and LATEST to clarify that they 
only restart when the topology is redeployed.


---