Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2465#discussion_r157347281 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -225,6 +237,23 @@ private long doSeek(TopicPartition tp, OffsetAndMetadata committedOffset) { } } + /** + * Checks If {@link OffsetAndMetadata} was committed by this topology, either by this or another spout instance. + * This info is used to decide if {@link FirstPollOffsetStrategy} should be applied + * + * @param committedOffset {@link OffsetAndMetadata} info committed to Kafka + * @return true if this topology committed this {@link OffsetAndMetadata}, false otherwise + */ + private boolean isOffsetCommittedByThisTopology(OffsetAndMetadata committedOffset) { + try { + return committedOffset != null && JSON_MAPPER.readValue(committedOffset.metadata(), KafkaSpoutMessageId.class) --- End diff -- Agree. Up to this point this was a bug. I guess we should default to the previous behavior before this fix, both in 1.x and 2.x. What do you think?
---