Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157347380
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java
---
@@ -290,8 +291,8 @@ public int readyMessageCount() {
}
@Override
- public KafkaSpoutMessageId getMessageId(ConsumerRecord<?, ?> record) {
- KafkaSpoutMessageId msgId = new KafkaSpoutMessageId(record);
+ public KafkaSpoutMessageId getMessageId(ConsumerRecord<?, ?> record,
TopologyContext context) {
--- End diff --
I guess the only non-backwards compatible changes are in case the user
implemented their own version of KafkaSpoutRetryService. Right? I will check if
it is possible to make this fix without this change. If possible I will do.
---
