Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157735221
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/internal/OffsetManagerTest.java
---
@@ -55,12 +58,12 @@ public void
testSkipMissingOffsetsWhenFindingNextCommitOffsetWithGapInMiddleOfAc
manager.addToAckMsgs(getMessageId(initialFetchOffset + 2));
manager.addToAckMsgs(getMessageId(initialFetchOffset + 6));
- assertThat("The offset manager should not skip past offset 5 which
is still pending", manager.findNextCommitOffset().offset(),
is(initialFetchOffset + 3));
+ assertThat("The offset manager should not skip past offset 5 which
is still pending", manager.findNextCommitOffset(COMMIT_METADATA).offset(),
is(initialFetchOffset + 3));
manager.addToAckMsgs(getMessageId(initialFetchOffset + 5));
assertThat("The offset manager should skip past the gap in acked
messages, since the messages were not emitted",
- manager.findNextCommitOffset().offset(), is(initialFetchOffset
+ 7));
+ manager.findNextCommitOffset(COMMIT_METADATA).offset(),
is(initialFetchOffset + 7));
--- End diff --
It would be good to add a new test that verifies that the OffsetAndMetadata
that is returned from findNextCommitOffset has the right metadata set.
---
