Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2465#discussion_r157728758
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
 ---
    @@ -115,26 +115,30 @@ public KafkaSpoutConfig(Builder<K, V> builder) {
         }
     
         /**
    -     * The offset used by the Kafka spout in the first poll to Kafka 
broker. The choice of this parameter will affect the number of consumer
    -     * records returned in the first poll. By default this parameter is 
set to UNCOMMITTED_EARLIEST. <br/><br/>
    +     * Defines the offset used by the {@link KafkaSpout} in the first poll 
to Kafka broker. The choice of this parameter will affect
    +     * the number of consumer records returned in the first poll. By 
default this parameter is set to UNCOMMITTED_EARLIEST. <br/><br/>
    --- End diff --
    
    I know you didn't change this, but the comment here is misleading. The 
parameter will determine the offset the consumer will seek to, not the number 
of consumer records returned in the first poll.


---

Reply via email to