Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157809222
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -115,26 +115,30 @@ public KafkaSpoutConfig(Builder<K, V> builder) {
}
/**
- * The offset used by the Kafka spout in the first poll to Kafka
broker. The choice of this parameter will affect the number of consumer
- * records returned in the first poll. By default this parameter is
set to UNCOMMITTED_EARLIEST. <br/><br/>
+ * Defines the offset used by the {@link KafkaSpout} in the first poll
to Kafka broker. The choice of this parameter will affect
+ * the number of consumer records returned in the first poll. By
default this parameter is set to UNCOMMITTED_EARLIEST. <br/><br/>
* The allowed values are EARLIEST, LATEST, UNCOMMITTED_EARLIEST,
UNCOMMITTED_LATEST. <br/>
* <ul>
- * <li>EARLIEST means that the kafka spout polls records starting in
the first offset of the partition, regardless of previous
- * commits</li>
- * <li>LATEST means that the kafka spout polls records with offsets
greater than the last offset in the partition, regardless of
- * previous commits</li>
+ * <li>EARLIEST when the topology is first deployed the kafka spout
polls records starting in the first offset of the
+ * partition, regardless of previous commits. When the topology is
activated/deactivated this setting has no effect</li>
+ * <li>LATEST when the topology is first deployed the kafka spout
polls records with offsets greater than the last offset
+ * in the partition, regardless of previous commits. If the topology
is activated/deactivated this setting has no effect</li>
* <li>UNCOMMITTED_EARLIEST means that the kafka spout polls records
from the last committed offset, if any. If no offset has been
* committed, it behaves as EARLIEST.</li>
* <li>UNCOMMITTED_LATEST means that the kafka spout polls records
from the last committed offset, if any. If no offset has been
* committed, it behaves as LATEST.</li>
* </ul>
- *
*/
- public static enum FirstPollOffsetStrategy {
+ public enum FirstPollOffsetStrategy {
--- End diff --
Enums are inherently static - it's redundant
---
