[GitHub] storm pull request #2465: STORM-2844: KafkaSpout Throws IllegalStateExceptio...

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2465#discussion_r157734918
  
    --- Diff: 
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/MaxUncommittedOffsetTest.java
 ---
    @@ -71,6 +75,10 @@
                 1, 
KafkaSpoutRetryExponentialBackoff.TimeInterval.seconds(initialRetryDelaySecs))) 
//Retry once after a minute
             .build();
         private KafkaSpout<String, String> spout;
    +    private final TopicPartition topicPartition = new 
TopicPartition(SingleTopicKafkaSpoutConfiguration.TOPIC, 1);
    +    private KafkaConsumer<String, String> consumerMock;
    --- End diff --
    
    This test runs against real Kafka, so you don't need to (and shouldn't) 
mock the consumer.


---