Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2634#discussion_r182750384
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -3032,9 +3019,19 @@ public void submitTopologyWithOpts(String topoName,
String uploadedJarLocation,
// if the other config does not have it set.
topology = normalizeTopology(totalConf, topology);
- //set the number of acker executors;
- totalConfToSave.put(Config.TOPOLOGY_ACKER_EXECUTORS,
getNumOfAckerExecs(totalConf, topology));
- LOG.debug("Config.TOPOLOGY_ACKER_EXECUTORS set to: {}",
totalConfToSave.get(Config.TOPOLOGY_ACKER_EXECUTORS));
+ // if the Resource Aware Scheduler is used,
+ // we might need to set the number of acker executors and
eventlogger executors to be the estimated number of workers.
+ if (ServerUtils.isRAS(conf)) {
+ int estimatedNumWorker =
ServerUtils.getEstimatedWorkerCountForRASTopo(totalConf, topology);
+ int numAckerExecs =
ObjectReader.getInt(totalConf.get(Config.TOPOLOGY_ACKER_EXECUTORS),
estimatedNumWorker);
+ int numEventLoggerExecs =
ObjectReader.getInt(totalConf.get(Config.TOPOLOGY_EVENTLOGGER_EXECUTORS),
estimatedNumWorker);
+
+ totalConfToSave.put(Config.TOPOLOGY_ACKER_EXECUTORS,
numAckerExecs);
--- End diff --
No we are not overriding the user setting. We are overriding the default
value.
---
