Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2634#discussion_r183051697
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -305,8 +305,9 @@ private void setupFlushTupleTimer(final Map<String,
Object> topologyConf, final
}
private void setupBackPressureCheckTimer(final Map<String, Object>
topologyConf) {
- final Integer workerCount =
ObjectReader.getInt(topologyConf.get(Config.TOPOLOGY_WORKERS));
- if (workerCount <= 1) {
+ Set<Integer> nonLocalTasks =
Sets.difference(workerState.getTaskToComponent().keySet(),
--- End diff --
`Sets.difference()` is already a named function and it's almost one line of
code. I think it's OK to just use it in this way?
---