Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2634#discussion_r182757546
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -305,8 +305,9 @@ private void setupFlushTupleTimer(final Map<String,
Object> topologyConf, final
}
private void setupBackPressureCheckTimer(final Map<String, Object>
topologyConf) {
- final Integer workerCount =
ObjectReader.getInt(topologyConf.get(Config.TOPOLOGY_WORKERS));
- if (workerCount <= 1) {
+ Set<Integer> nonLocalTasks =
Sets.difference(workerState.getTaskToComponent().keySet(),
--- End diff --
About the `set difference calls`, I thought these two are different. The
first one
https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java#L230
is to check if there is any outbound task not in local worker. This doesn't
necessarily mean the topology has only one worker.
The second (in setupBackPressureCheckTimer) is to check if all the tasks
are in local which means there is only one worker.
---
