[GitHub] storm pull request #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_W...

[roshannaik]

Github user roshannaik commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2634#discussion_r182909146
  
    --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java 
---
    @@ -305,8 +305,9 @@ private void setupFlushTupleTimer(final Map<String, 
Object> topologyConf, final
         }
     
         private void setupBackPressureCheckTimer(final Map<String, Object> 
topologyConf) {
    -        final Integer workerCount = 
ObjectReader.getInt(topologyConf.get(Config.TOPOLOGY_WORKERS));
    -        if (workerCount <= 1) {
    +        Set<Integer> nonLocalTasks = 
Sets.difference(workerState.getTaskToComponent().keySet(),
    --- End diff --
    
    Thanks for clarifications. IMO, thats a nice (eventhough small) improvement 
to disable interworker when there are no outbound tasks... and not just for 
1worker mode. 
    
    Minor request: would be nice to have named functions for those two set 
difference calls. I suspect they will start seeing more usage soon.
    
    looks good thanks for taking care of this.



---