Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208706459
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/WorkerLogs.java
---
@@ -88,9 +87,14 @@ public void setLogFilePermission(String fileName) throws
IOException {
if (runAsUser && topoOwner.isPresent() && file.exists() &&
!Files.isReadable(file.toPath())) {
LOG.debug("Setting permissions on file {} with topo-owner {}",
fileName, topoOwner);
- ClientSupervisorUtils.processLauncherAndWait(stormConf,
topoOwner.get(),
- Lists.newArrayList("blob", file.getCanonicalPath()),
null,
- "setup group read permissions for file: " + fileName);
+ try {
+ ClientSupervisorUtils.processLauncherAndWait(stormConf,
topoOwner.get(),
+ Lists.newArrayList("blob",
file.getCanonicalPath()), null,
+ "setup group read permissions for file: " +
fileName);
+ } catch (IOException e) {
+ ExceptionMeters.NUM_PERMISSION_EXCEPTIONS.mark();
--- End diff --
The exception name is not clear
---
