[GitHub] storm pull request #2754: STORM-3133: Extend metrics on Nimbus and LogViewer

[Ethanlm]

Github user Ethanlm commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2754#discussion_r208704852
  
    --- Diff: 
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
 ---
    @@ -223,8 +246,8 @@ void cleanupEmptyTopoDirectory(File dir) throws 
IOException {
     
         @VisibleForTesting
         FileFilter mkFileFilterForLogCleanup(long nowMillis) {
    -        final long cutoffAgeMillis = cleanupCutoffAgeMillis(nowMillis);
    -        return file -> !file.isFile() && 
lastModifiedTimeWorkerLogdir(file) <= cutoffAgeMillis;
    +        //Doesn't it make more sense to do file.isDirectory here?
    --- End diff --
    
    I agree. Also the name of this method is not clear


---