Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208705884
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogFileDownloader.java
---
@@ -55,6 +63,8 @@ public Response downloadFile(String fileName, String
user, boolean isDaemon) thr
File file = new File(rootDir, fileName).getCanonicalFile();
if (file.exists()) {
if (isDaemon ||
resourceAuthorizer.isUserAllowedToAccessFile(user, fileName)) {
+ //How should I put the constant for magic numbers?
--- End diff --
It's fine here.
---
