Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209004673
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer tryParseIntParam(String paramName,
String value) throws InvalidR
}
}
+ /**
+ * Find the first N matches of target string in files.
+ * @param logs all candidate log files to search
+ * @param numMatches number of matches expected
+ * @param fileOffset
Unclear metrics
--- End diff --
I remembered. I asked Bobby once about this and we both don't know what
this parameter is used for. Additionally it's not used anywhere in code. So I
was wondering if we could remove this parameter altogether.
---
