Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2754#discussion_r209078742
  
    --- Diff: 
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogPageHandler.java
 ---
    @@ -61,18 +63,21 @@
     import org.apache.commons.lang.StringUtils;
     import org.apache.storm.daemon.logviewer.LogviewerConstant;
     import org.apache.storm.daemon.logviewer.utils.DirectoryCleaner;
    +import org.apache.storm.daemon.logviewer.utils.ExceptionMeters;
     import org.apache.storm.daemon.logviewer.utils.LogviewerResponseBuilder;
     import org.apache.storm.daemon.logviewer.utils.ResourceAuthorizer;
     import org.apache.storm.daemon.logviewer.utils.WorkerLogs;
     import org.apache.storm.daemon.ui.InvalidRequestException;
     import org.apache.storm.daemon.ui.UIHelpers;
     import org.apache.storm.daemon.utils.StreamUtil;
     import org.apache.storm.daemon.utils.UrlBuilder;
    +import org.apache.storm.metric.StormMetricsRegistry;
     import org.apache.storm.utils.ConfigUtils;
     import org.apache.storm.utils.ServerUtils;
     import org.jooq.lambda.Unchecked;
     
     public class LogviewerLogPageHandler {
    +    private static final Meter numPageRead = 
StormMetricsRegistry.registerMeter("logviewer:num-page-read");
    --- End diff --
    
    What is this metric useful for?


---

Reply via email to