Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2754#discussion_r209078282
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
    @@ -251,10 +257,18 @@
         private static final Meter getTopologyPageInfoCalls = 
StormMetricsRegistry.registerMeter("nimbus:num-getTopologyPageInfo-calls");
         private static final Meter getSupervisorPageInfoCalls = 
StormMetricsRegistry.registerMeter("nimbus:num-getSupervisorPageInfo-calls");
         private static final Meter getComponentPageInfoCalls = 
StormMetricsRegistry.registerMeter("nimbus:num-getComponentPageInfo-calls");
    -    private static final Histogram scheduleTopologyTimeMs = 
StormMetricsRegistry.registerHistogram("nimbus:time-scheduleTopology-ms",
    -                                                                           
                        new ExponentiallyDecayingReservoir());
         private static final Meter getOwnerResourceSummariesCalls = 
StormMetricsRegistry.registerMeter(
             "nimbus:num-getOwnerResourceSummaries-calls");
    +    //Timer
    +    private static final Timer fileUploadDuration = 
StormMetricsRegistry.registerTimer("nimbus:files-upload-duration-ms");
    +    private static final Timer schedulingDuration = 
StormMetricsRegistry.registerTimer("nimbus:topology-scheduling-duration-ms");
    +    //Scheduler histogram
    +    private static final Histogram numAddedExecPerScheduling = 
StormMetricsRegistry.registerHistogram("nimbus:num-added-executors-per-scheduling",
 new ExponentiallyDecayingReservoir());
    +    private static final Histogram numAddedSlotPerScheduling = 
StormMetricsRegistry.registerHistogram("nimbus:num-added-slots-per-scheduling", 
new ExponentiallyDecayingReservoir());
    +    private static final Histogram numRemovedExecPerScheduling = 
StormMetricsRegistry.registerHistogram("nimbus:num-removed-executors-per-scheduling",
 new ExponentiallyDecayingReservoir());
    +    private static final Histogram numRemovedSlotPerScheduling = 
StormMetricsRegistry.registerHistogram("nimbus:num-removed-slots-per-scheduling",
 new ExponentiallyDecayingReservoir());
    +    private static final Histogram numNetExecIncreasePerScheduling = 
StormMetricsRegistry.registerHistogram("nimbus:num-net-executors-changed-per-scheduling",
 new ExponentiallyDecayingReservoir());
    --- End diff --
    
    The variable name says it's exec increase, but the metric name says it's 
the number changed.


---

Reply via email to