Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2789#discussion_r209301643
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java
---
@@ -316,7 +317,7 @@ public void launchDaemon() {
//This will only get updated once
StormMetricsRegistry.registerMeter("supervisor:num-launched").mark();
StormMetricsRegistry.registerMeter("supervisor:num-shell-exceptions",
ShellUtils.numShellExceptions);
- StormMetricsRegistry.startMetricsReporters(conf);
+ metricsReporters =
StormMetricsRegistry.startMetricsReporters(conf);
--- End diff --
since you are not really returning metricsReporters here, better not to use
this name `metricsReporters`
---
