Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2789#discussion_r209274375
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -96,4 +99,10 @@ public static void startMetricsReporters(Map<String,
Object> topoConf) {
throw e;
}
}
+
+ @FunctionalInterface
+ public interface Session extends AutoCloseable {
--- End diff --
Do we need this? We can have `startMetricsReporters` returns
preparableReporters. It will be more clear.
But if you prefer to keep this, you might want to pick a better name
because this is way to general
---
