[GitHub] storm pull request #2789: STORM-3173: flush metrics to ScheduledReporter on ...

[Ethanlm]

Github user Ethanlm commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2789#discussion_r209271682
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/metrics/reporters/JmxPreparableReporter.java
 ---
    @@ -22,9 +22,9 @@
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
     
    -public class JmxPreparableReporter implements 
PreparableReporter<JmxReporter> {
    +public class JmxPreparableReporter implements PreparableReporter {
    --- End diff --
    
    why not extending `ScheduledReporter`


---