Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2789#discussion_r209269207
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/metrics/reporters/ConsolePreparableReporter.java
---
@@ -18,16 +18,12 @@
import java.util.Map;
import java.util.concurrent.TimeUnit;
import org.apache.storm.daemon.metrics.ClientMetricsUtils;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-public class ConsolePreparableReporter implements
PreparableReporter<ConsoleReporter> {
- private static final Logger LOG =
LoggerFactory.getLogger(ConsolePreparableReporter.class);
- ConsoleReporter reporter = null;
+public class ConsolePreparableReporter extends
ScheduledPreparableReporter<ConsoleReporter> {
@Override
public void prepare(MetricRegistry metricsRegistry, Map<String,
Object> topoConf) {
- LOG.debug("Preparing...");
+ log.debug("Preparing...");
--- End diff --
`LOG` is used everywhere. I think it's better to use `LOG` here too
---
