Ethanlm commented on a change in pull request #3420:
URL: https://github.com/apache/storm/pull/3420#discussion_r738764480
##########
File path:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/topology.html
##########
@@ -331,22 +331,27 @@ <h2 id="topology-resources-header">Topology resources</h2>
info: false,
searching: false,
columnDefs: [
- {type: "num", targets: [1, 2, 3, 4, 5]},
+ {type: "num", targets: [1, 2, 4, 5], render:
$.fn.dataTable.render.number( ',', '.', 0)},
+ {type: "num", targets: [3]},
{type: "time-str", targets: [0]}
]
});
spoutStats.append(Mustache.render($(template).filter("#spout-stats-template").html(),response));
+ // id, executors, tasks, emitted, transferred, latency, acked,
failed, error host, error port, last error, error time
Review comment:
This doesn't seem to match the template in
https://github.com/apache/storm/blob/master/storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/templates/topology-page-template.html#L355
We should test it with schedulerDisplayResource enabled too
##########
File path:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/supervisor.html
##########
@@ -121,10 +121,11 @@ <h2 id="worker-resources-header">Worker resources</h2>
supervisorSummary.append(
Mustache.render($(template).filter("#supervisor-summary-template").html(),response));
- //id, host, uptime, slots, used slots
+ //host, supervisor id, uptime, slots, used slots, used mem,
version, blacklisted
Review comment:
This doesn't seem to match the order listed here in the template
https://github.com/apache/storm/blob/master/storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/templates/supervisor-page-template.html#L17
##########
File path:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/topology.html
##########
@@ -331,22 +331,27 @@ <h2 id="topology-resources-header">Topology resources</h2>
info: false,
searching: false,
columnDefs: [
- {type: "num", targets: [1, 2, 3, 4, 5]},
+ {type: "num", targets: [1, 2, 4, 5], render:
$.fn.dataTable.render.number( ',', '.', 0)},
+ {type: "num", targets: [3]},
{type: "time-str", targets: [0]}
]
});
spoutStats.append(Mustache.render($(template).filter("#spout-stats-template").html(),response));
+ // id, executors, tasks, emitted, transferred, latency, acked,
failed, error host, error port, last error, error time
dtAutoPage("#spout-stats-table", {
columnDefs: [
- {type: "num", targets: 'table-num'}
+ {type: "num", targets: [1, 2, 5]},
+ {type: "num", targets: [3, 4, 6, 7], render:
$.fn.dataTable.render.number( ',', '.', 0)}
]
});
boltStats.append(Mustache.render($(template).filter("#bolt-stats-template").html(),response));
+ // id, executors, tasks, emitted, transferred, capacity, exec
latency, executed, process latency, acked, failed, error host, error port, last
error, error time
dtAutoPage("#bolt-stats-table", {
columnDefs: [
- {type: "num", targets: 'table-num'}
+ {type: "num", targets: [1, 2, 5, 6, 8, 12]},
+ {type: "num", targets: [3, 4, 7, 9, 10], render:
$.fn.dataTable.render.number( ',', '.', 0)}
Review comment:
nit: remove the first space in `number( ',', '.', 0)}`
##########
File path:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/topology.html
##########
@@ -331,22 +331,27 @@ <h2 id="topology-resources-header">Topology resources</h2>
info: false,
searching: false,
columnDefs: [
- {type: "num", targets: [1, 2, 3, 4, 5]},
+ {type: "num", targets: [1, 2, 4, 5], render:
$.fn.dataTable.render.number( ',', '.', 0)},
+ {type: "num", targets: [3]},
{type: "time-str", targets: [0]}
]
});
spoutStats.append(Mustache.render($(template).filter("#spout-stats-template").html(),response));
+ // id, executors, tasks, emitted, transferred, latency, acked,
failed, error host, error port, last error, error time
dtAutoPage("#spout-stats-table", {
columnDefs: [
- {type: "num", targets: 'table-num'}
+ {type: "num", targets: [1, 2, 5]},
+ {type: "num", targets: [3, 4, 6, 7], render:
$.fn.dataTable.render.number( ',', '.', 0)}
]
});
boltStats.append(Mustache.render($(template).filter("#bolt-stats-template").html(),response));
+ // id, executors, tasks, emitted, transferred, capacity, exec
latency, executed, process latency, acked, failed, error host, error port, last
error, error time
Review comment:
this too
https://github.com/apache/storm/blob/master/storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/templates/topology-page-template.html#L459
##########
File path:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/owner.html
##########
@@ -187,14 +187,14 @@ <h2>Owner Topologies</h2>
topologySummary.append(
Mustache.render($(template).filter("#owner-topology-summary-template").html(),
response));
- //name, owner, status, uptime, num workers, num executors,
num tasks, assigned total mem, assigned total cpu, scheduler info
+ //name, owner, status, uptime, num workers, num executors,
num tasks, assigned total mem, assigned total cpu, scheduler info, topology
version, storm version
dtAutoPage("#owner-topology-summary-table", {
columnDefs: [{
- type: "num",
- targets: [4, 5, 6, 7, 8]
Review comment:
8 seems removed here. Do we need to keep it? Or it is default to "num"
type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
