bipinprasad commented on a change in pull request #3420:
URL: https://github.com/apache/storm/pull/3420#discussion_r739552721



##########
File path: 
storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/owner.html
##########
@@ -187,14 +187,14 @@ <h2>Owner Topologies</h2>
 
                     topologySummary.append(
                         
Mustache.render($(template).filter("#owner-topology-summary-template").html(), 
response));
-                    //name, owner, status, uptime, num workers, num executors, 
num tasks, assigned total mem, assigned total cpu, scheduler info
+                    //name, owner, status, uptime, num workers, num executors, 
num tasks, assigned total mem, assigned total cpu, scheduler info, topology 
version, storm version
                     dtAutoPage("#owner-topology-summary-table", {
                         columnDefs: [{
-                            type: "num",
-                            targets: [4, 5, 6, 7, 8]

Review comment:
       Column 8 only exists when schedulerDisplayResource is enabled. Along 
with he changes below, I have added conditional formatting to this table as 
well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to