bipinprasad commented on a change in pull request #3420:
URL: https://github.com/apache/storm/pull/3420#discussion_r739306165



##########
File path: 
storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/supervisor.html
##########
@@ -121,10 +121,11 @@ <h2 id="worker-resources-header">Worker resources</h2>
                 supervisorSummary.append(
                         
Mustache.render($(template).filter("#supervisor-summary-template").html(),response));
                 
-                //id, host, uptime, slots, used slots
+                //host, supervisor id, uptime, slots, used slots, used mem, 
version, blacklisted

Review comment:
       That comment line matches the template without the conditional columns. 
My intent was to fix the first two columns that were obviously reversed and add 
the column being formatted. Open to suggestion on this comment line. The total 
order of lines is thus: 
                 Host
                 Supervisor Id
                 Uptime
                 Slots
                 Used slots
                     **scheduler-display-resource (conditional columns below)
                        Total Mem (MB) 
                        Used Mem (MB)
                        Avail Mem (MB)
                        Total CPU (%)
                        Used CPU (%)
                        Avail CPU (%)
                        Total Generic Resources
                        Used Generic Resources
                        Avail Generic Resources
                     **schedulerDisplayResource (conditional columns above)
                 Version
                 Blacklisted
    




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to