bipinprasad commented on a change in pull request #3420:
URL: https://github.com/apache/storm/pull/3420#discussion_r739318407



##########
File path: 
storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/topology.html
##########
@@ -331,22 +331,27 @@ <h2 id="topology-resources-header">Topology resources</h2>
               info: false,
               searching: false,
               columnDefs: [
-                {type: "num", targets: [1, 2, 3, 4, 5]},
+                {type: "num", targets: [1, 2, 4, 5], render: 
$.fn.dataTable.render.number( ',', '.', 0)},
+                {type: "num", targets: [3]},
                 {type: "time-str", targets: [0]}
               ]
             });
 
             
spoutStats.append(Mustache.render($(template).filter("#spout-stats-template").html(),response));
+            // id, executors, tasks, emitted, transferred, latency, acked, 
failed, error host, error port, last error, error time

Review comment:
                   Id
               Executors
               Tasks
               ** {{#schedulerDisplayResource}} optional fields below
                   Req On-heap Mem (MB)
                   Req Off-heap Mem (MB)
                   Req CPU
                   Req Generic
              ** {{/schedulerDisplayResource}} optional fields above
               Emitted
               Transferred
               Complete latency (ms)
               Acked
               Failed
               Error Host
               Error Port
               Last error
               Error Time
   So the columns being formatted 3, 4, 6, 7 seem to be compromise without 
conditional logic while skipping the latency field. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to