bipinprasad commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r879900379
##########
external/storm-jdbc/src/test/java/org/apache/storm/jdbc/common/UtilTest.java:
##########
@@ -46,20 +46,7 @@ public void testBasic() {
@Test
public void testError() {
- //This test is rather ugly, but it is the only way to see if the error
messages are working correctly.
- try {
- Util.getJavaType(Types.REF);
- fail("didn't throw like expected");
- } catch (Exception e) {
- assertEquals("We do not support tables with SqlType: REF",
e.getMessage());
- }
-
- try {
- Util.getJavaType(-1000);
- fail("didn't throw like expected");
- } catch (Exception e) {
- assertEquals("Unknown sqlType -1000", e.getMessage());
- }
-
+ assertThrows(RuntimeException.class, () ->
Util.getJavaType(Types.REF));
Review Comment:
instead of RuntimeException, these should be Exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
