bipinprasad commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r879912690
##########
integration-test/src/test/java/org/apache/storm/st/tests/window/SlidingWindowTest.java:
##########
@@ -94,7 +90,7 @@ public void testTimeWindow(int windowSec, int slideSec)
throws Exception {
if (windowSec <= 0 || slideSec <= 0) {
try {
testable.newTopology();
- Assert.fail("Expected IllegalArgumentException was not
thrown.");
+ fail("Expected IllegalArgumentException was not thrown.");
} catch (IllegalArgumentException ignore) {
return;
}
Review Comment:
use asserThrows()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
