[GitHub] [storm] bipinprasad commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5

[GitBox]

bipinprasad commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r879912983


##########
integration-test/src/test/java/org/apache/storm/st/tests/window/TumblingWindowTest.java:
##########
@@ -53,7 +51,7 @@ public void testTumbleCount(int tumbleSize) throws Exception {
         if (tumbleSize <= 0) {
             try {
                 testable.newTopology();
-                Assert.fail("Expected IllegalArgumentException was not 
thrown.");
+                fail("Expected IllegalArgumentException was not thrown.");
             } catch (IllegalArgumentException ignore) {
                 return;
             }

Review Comment:
   use assertThrows()



##########
integration-test/src/test/java/org/apache/storm/st/tests/window/TumblingWindowTest.java:
##########
@@ -82,7 +80,7 @@ public void testTumbleTime(int tumbleSec) throws Exception {
         if (tumbleSec <= 0) {
             try {
                 testable.newTopology();
-                Assert.fail("Expected IllegalArgumentException was not 
thrown.");
+                fail("Expected IllegalArgumentException was not thrown.");
             } catch (IllegalArgumentException ignore) {
                 return;
             }

Review Comment:
   use assertThrows()



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org