snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885141228
##########
storm-client/test/jvm/org/apache/storm/TestConfigValidate.java:
##########
@@ -822,20 +805,19 @@ public void TestImpersonationAclUserEntryValidator()
throws InvocationTargetExce
for (Object value : passCases) {
config.put(TestConfig.TEST_MAP_CONFIG_6, value);
- ConfigValidation.validateFields(config,
Arrays.asList(TestConfig.class));
+ ConfigValidation.validateFields(config,
Collections.singletonList(TestConfig.class));
}
- Map<String, Map<String, List<String>>> failCase1 = new HashMap<String,
Map<String, List<String>>>();
- Map<String, List<String>> failCase1_hostsAndGroups = new
HashMap<String, List<String>>();
- String[] failhosts = { "host.1", "host.2", "host.3" };
+ Map<String, Map<String, List<String>>> failCase1 = new HashMap<>();
+ Map<String, List<String>> failCase1_hostsAndGroups = new HashMap<>();
failCase1_hostsAndGroups.put("hosts", Arrays.asList(hosts));
failCase1.put("jerry", failCase1_hostsAndGroups);
- Map<String, Map<String, List<String>>> failCase2 = new HashMap<String,
Map<String, List<String>>>();
- Map<String, List<String>> failCase2_hostsAndGroups = new
HashMap<String, List<String>>();
+ Map<String, Map<String, List<String>>> failCase2 = new HashMap<>();
+ Map<String, List<String>> failCase2_hostsAndGroups = new HashMap<>();
String[] failgroups = { "group.1", "group.2", "group.3" };
- failCase2_hostsAndGroups.put("groups", Arrays.asList(groups));
+ failCase2_hostsAndGroups.put("groups", Arrays.asList(groups)); //
should this be failGroups ?
Review Comment:
removed comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
