snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885705401
##########
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/TestSequenceFileBolt.java:
##########
@@ -40,38 +40,30 @@
import org.apache.storm.tuple.Tuple;
import org.apache.storm.tuple.TupleImpl;
import org.apache.storm.tuple.Values;
-import org.junit.After;
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.ExpectedException;
-import org.junit.runner.RunWith;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.extension.RegisterExtension;
import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
import org.mockito.runners.MockitoJUnitRunner;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyZeroInteractions;
-@RunWith(MockitoJUnitRunner.class)
+@ExtendWith(MockitoExtension.class)
public class TestSequenceFileBolt {
private static final Logger LOG =
LoggerFactory.getLogger(TestSequenceFileBolt.class);
private static final String testRoot = "/unittest";
- @Rule
- public MiniDFSClusterRule dfsClusterRule = new MiniDFSClusterRule(() -> {
- Configuration conf = new Configuration();
- conf.set("fs.trash.interval", "10");
- conf.setBoolean("dfs.permissions", true);
- File baseDir = new File("./target/hdfs/").getAbsoluteFile();
- FileUtil.fullyDelete(baseDir);
- conf.set(MiniDFSCluster.HDFS_MINIDFS_BASEDIR,
baseDir.getAbsolutePath());
- return conf;
- });
- @Rule
- public ExpectedException thrown = ExpectedException.none();
+ @RegisterExtension
+ public static final MiniDFSClusterExtension DFS_CLUSTER_EXTENSION = new
MiniDFSClusterExtension();
Review Comment:
done
##########
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java:
##########
@@ -419,45 +419,45 @@ public void testMultipleFileConsumption_Ack() throws
Exception {
// read few lines from file1 dont ack
runSpout(spout, "r3");
FileReader reader = getField(spout, "reader");
- Assert.assertNotNull(reader);
- Assert.assertEquals(false, getBoolField(spout,
"fileReadCompletely"));
+ assertNotNull(reader);
+ assertEquals(false, getBoolField(spout, "fileReadCompletely"));
Review Comment:
done
##########
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java:
##########
@@ -419,45 +419,45 @@ public void testMultipleFileConsumption_Ack() throws
Exception {
// read few lines from file1 dont ack
runSpout(spout, "r3");
FileReader reader = getField(spout, "reader");
- Assert.assertNotNull(reader);
- Assert.assertEquals(false, getBoolField(spout,
"fileReadCompletely"));
+ assertNotNull(reader);
+ assertEquals(false, getBoolField(spout, "fileReadCompletely"));
// read remaining lines
runSpout(spout, "r3");
reader = getField(spout, "reader");
- Assert.assertNotNull(reader);
- Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+ assertNotNull(reader);
+ assertEquals(true, getBoolField(spout, "fileReadCompletely"));
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
