snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885705645
##########
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java:
##########
@@ -419,45 +419,45 @@ public void testMultipleFileConsumption_Ack() throws
Exception {
// read few lines from file1 dont ack
runSpout(spout, "r3");
FileReader reader = getField(spout, "reader");
- Assert.assertNotNull(reader);
- Assert.assertEquals(false, getBoolField(spout,
"fileReadCompletely"));
+ assertNotNull(reader);
+ assertEquals(false, getBoolField(spout, "fileReadCompletely"));
// read remaining lines
runSpout(spout, "r3");
reader = getField(spout, "reader");
- Assert.assertNotNull(reader);
- Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+ assertNotNull(reader);
+ assertEquals(true, getBoolField(spout, "fileReadCompletely"));
// ack few
runSpout(spout, "a0", "a1", "a2");
reader = getField(spout, "reader");
- Assert.assertNotNull(reader);
- Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+ assertNotNull(reader);
+ assertEquals(true, getBoolField(spout, "fileReadCompletely"));
Review Comment:
done
##########
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java:
##########
@@ -419,45 +419,45 @@ public void testMultipleFileConsumption_Ack() throws
Exception {
// read few lines from file1 dont ack
runSpout(spout, "r3");
FileReader reader = getField(spout, "reader");
- Assert.assertNotNull(reader);
- Assert.assertEquals(false, getBoolField(spout,
"fileReadCompletely"));
+ assertNotNull(reader);
+ assertEquals(false, getBoolField(spout, "fileReadCompletely"));
// read remaining lines
runSpout(spout, "r3");
reader = getField(spout, "reader");
- Assert.assertNotNull(reader);
- Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+ assertNotNull(reader);
+ assertEquals(true, getBoolField(spout, "fileReadCompletely"));
// ack few
runSpout(spout, "a0", "a1", "a2");
reader = getField(spout, "reader");
- Assert.assertNotNull(reader);
- Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+ assertNotNull(reader);
+ assertEquals(true, getBoolField(spout, "fileReadCompletely"));
//ack rest
runSpout(spout, "a3", "a4");
reader = getField(spout, "reader");
- Assert.assertNull(reader);
- Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+ assertNull(reader);
+ assertEquals(true, getBoolField(spout, "fileReadCompletely"));
Review Comment:
done
##########
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java:
##########
@@ -419,45 +419,45 @@ public void testMultipleFileConsumption_Ack() throws
Exception {
// read few lines from file1 dont ack
runSpout(spout, "r3");
FileReader reader = getField(spout, "reader");
- Assert.assertNotNull(reader);
- Assert.assertEquals(false, getBoolField(spout,
"fileReadCompletely"));
+ assertNotNull(reader);
+ assertEquals(false, getBoolField(spout, "fileReadCompletely"));
// read remaining lines
runSpout(spout, "r3");
reader = getField(spout, "reader");
- Assert.assertNotNull(reader);
- Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+ assertNotNull(reader);
+ assertEquals(true, getBoolField(spout, "fileReadCompletely"));
// ack few
runSpout(spout, "a0", "a1", "a2");
reader = getField(spout, "reader");
- Assert.assertNotNull(reader);
- Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+ assertNotNull(reader);
+ assertEquals(true, getBoolField(spout, "fileReadCompletely"));
//ack rest
runSpout(spout, "a3", "a4");
reader = getField(spout, "reader");
- Assert.assertNull(reader);
- Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+ assertNull(reader);
+ assertEquals(true, getBoolField(spout, "fileReadCompletely"));
// go to next file
Path file2 = new Path(source.toString() + "/file2.txt");
createTextFile(file2, 5);
// Read 1 line
runSpout(spout, "r1");
- Assert.assertNotNull(getField(spout, "reader"));
- Assert.assertEquals(false, getBoolField(spout,
"fileReadCompletely"));
+ assertNotNull(getField(spout, "reader"));
+ assertEquals(false, getBoolField(spout, "fileReadCompletely"));
Review Comment:
done
##########
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java:
##########
@@ -419,45 +419,45 @@ public void testMultipleFileConsumption_Ack() throws
Exception {
// read few lines from file1 dont ack
runSpout(spout, "r3");
FileReader reader = getField(spout, "reader");
- Assert.assertNotNull(reader);
- Assert.assertEquals(false, getBoolField(spout,
"fileReadCompletely"));
+ assertNotNull(reader);
+ assertEquals(false, getBoolField(spout, "fileReadCompletely"));
// read remaining lines
runSpout(spout, "r3");
reader = getField(spout, "reader");
- Assert.assertNotNull(reader);
- Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+ assertNotNull(reader);
+ assertEquals(true, getBoolField(spout, "fileReadCompletely"));
// ack few
runSpout(spout, "a0", "a1", "a2");
reader = getField(spout, "reader");
- Assert.assertNotNull(reader);
- Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+ assertNotNull(reader);
+ assertEquals(true, getBoolField(spout, "fileReadCompletely"));
//ack rest
runSpout(spout, "a3", "a4");
reader = getField(spout, "reader");
- Assert.assertNull(reader);
- Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+ assertNull(reader);
+ assertEquals(true, getBoolField(spout, "fileReadCompletely"));
// go to next file
Path file2 = new Path(source.toString() + "/file2.txt");
createTextFile(file2, 5);
// Read 1 line
runSpout(spout, "r1");
- Assert.assertNotNull(getField(spout, "reader"));
- Assert.assertEquals(false, getBoolField(spout,
"fileReadCompletely"));
+ assertNotNull(getField(spout, "reader"));
+ assertEquals(false, getBoolField(spout, "fileReadCompletely"));
// ack 1 tuple
runSpout(spout, "a5");
- Assert.assertNotNull(getField(spout, "reader"));
- Assert.assertEquals(false, getBoolField(spout,
"fileReadCompletely"));
+ assertNotNull(getField(spout, "reader"));
+ assertEquals(false, getBoolField(spout, "fileReadCompletely"));
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
