[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5

[GitBox]

snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885708800


##########
storm-client/test/jvm/org/apache/storm/grouping/LoadAwareShuffleGroupingTest.java:
##########
@@ -204,24 +204,21 @@ private void 
testLoadAwareShuffleGroupingWithEvenLoadMultiThreaded(int numTasks)
 
         List<Callable<int[]>> threadTasks = Lists.newArrayList();
         for (int x = 0; x < numThreads; x++) {
-            Callable<int[]> threadTask = new Callable<int[]>() {
-                @Override
-                public int[] call() throws Exception {
-                    int[] taskCounts = new int[availableTaskIds.size()];
-                    for (int i = 1; i <= groupingExecutionsPerThread; i++) {
-                        List<Integer> taskIds = 
grouper.chooseTasks(inputTaskId, Lists.newArrayList());
-
-                        // Validate a single task id return
-                        assertNotNull("Not null taskId list returned", 
taskIds);
-                        assertEquals("Single task Id returned", 1, 
taskIds.size());
-
-                        int taskId = taskIds.get(0);
-
-                        assertTrue("TaskId should exist", taskId >= 0 && 
taskId < availableTaskIds.size());
-                        taskCounts[taskId]++;
-                    }
-                    return taskCounts;
+            Callable<int[]> threadTask = () -> {
+                int[] taskCounts = new int[availableTaskIds.size()];
+                for (int i = 1; i <= groupingExecutionsPerThread; i++) {
+                    List<Integer> taskIds = grouper.chooseTasks(inputTaskId, 
Lists.newArrayList());
+
+                    // Validate a single task id return
+                    assertNotNull(taskIds, "Not null taskId list returned");
+                    assertEquals(1, taskIds.size(), "Single task Id returned");

Review Comment:
   done



##########
storm-client/test/jvm/org/apache/storm/grouping/LoadAwareShuffleGroupingTest.java:
##########
@@ -385,12 +371,12 @@ private int[] 
runChooseTasksWithVerification(LoadAwareShuffleGrouping grouper, i
                 .chooseTasks(inputTaskId, Lists.newArrayList());
 
             // Validate a single task id return
-            assertNotNull("Not null taskId list returned", taskIds);
-            assertEquals("Single task Id returned", 1, taskIds.size());
+            assertNotNull(taskIds, "Not null taskId list returned");
+            assertEquals(1, taskIds.size(), "Single task Id returned");

Review Comment:
   done



##########
storm-client/test/jvm/org/apache/storm/grouping/ShuffleGroupingTest.java:
##########
@@ -55,17 +55,17 @@ public void testShuffleGrouping() {
             List<Integer> taskIds = grouper.chooseTasks(inputTaskId, 
Lists.newArrayList());
 
             // Validate a single task id return
-            assertNotNull("Not null taskId list returned", taskIds);
-            assertEquals("Single task Id returned", 1, taskIds.size());
+            assertNotNull(taskIds, "Not null taskId list returned");
+            assertEquals(1, taskIds.size(), "Single task Id returned");

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org