snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885709137
##########
storm-client/test/jvm/org/apache/storm/grouping/ShuffleGroupingTest.java:
##########
@@ -95,24 +95,21 @@ public void testShuffleGroupMultiThreaded() throws
InterruptedException, Executi
List<Callable<int[]>> threadTasks = Lists.newArrayList();
for (int x = 0; x < numThreads; x++) {
- Callable<int[]> threadTask = new Callable<int[]>() {
- @Override
- public int[] call() throws Exception {
- int[] taskCounts = new int[availableTaskIds.size()];
- for (int i = 1; i <= groupingExecutionsPerThread; i++) {
- List<Integer> taskIds =
grouper.chooseTasks(inputTaskId, Lists.newArrayList());
-
- // Validate a single task id return
- assertNotNull("Not null taskId list returned",
taskIds);
- assertEquals("Single task Id returned", 1,
taskIds.size());
-
- int taskId = taskIds.get(0);
-
- assertTrue("TaskId should exist", taskId >= 0 &&
taskId < availableTaskIds.size());
- taskCounts[taskId]++;
- }
- return taskCounts;
+ Callable<int[]> threadTask = () -> {
+ int[] taskCounts = new int[availableTaskIds.size()];
+ for (int i = 1; i <= groupingExecutionsPerThread; i++) {
+ List<Integer> taskIds = grouper.chooseTasks(inputTaskId,
Lists.newArrayList());
+
+ // Validate a single task id return
+ assertNotNull(taskIds, "Not null taskId list returned");
+ assertEquals(1, taskIds.size(), "Single task Id returned");
Review Comment:
done
##########
storm-client/test/jvm/org/apache/storm/security/auth/authorizer/DRPCSimpleACLAuthorizerTest.java:
##########
@@ -68,101 +68,101 @@ private static ReqContext makeMockContext(String user) {
@Test
public void test_partial_authorization() {
- Assert.assertFalse("Deny execute to unauthroized user",
- isPermitted(strictHandler, ReqContext.context(),
"execute", partialFunction));
+ assertFalse(isPermitted(strictHandler, ReqContext.context(),
"execute", partialFunction),
+ "Deny execute to unauthorized user");
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
