I have now added a validation to verify cartridge groups in applications, commit revision: 9b0b3df2fd93024fe725b87a0c59fdfd672e3d50
On Thu, Feb 19, 2015 at 9:54 AM, Reka Thirunavukkarasu <[email protected]> wrote: > That's great Imesh..Yah..We didn't implement the validation in the > pre-alpha due to the time constraint.. > > Thanks, > Reka > > On Wed, Feb 18, 2015 at 9:15 PM, Imesh Gunaratne <[email protected]> wrote: > >> Thanks Reka! Following are my current observations: >> >> - Currently there are no validations to verify whether a group added to >> an application has defined all the cartridges. At the moment this is not >> detected at any stage. >> - There are no validations to verify aliases. >> - IMO without validations, due to the complexity of the composite >> application model, it is nearly impossible for an user to figure out what's >> wrong with his application, which means validations are a must! >> - We need to use the term "Reference" when referring an already defined >> entity. For an example when using a cartridge group in an application we >> need to call it Group Reference. Otherwise users may think that they are >> defining the cartridge group inline. >> - Aliases, group names and ids are mixed in deployment process. >> >> I'm now in the process of fixing above. >> >> Thanks >> >> On Thu, Feb 19, 2015 at 9:26 AM, Reka Thirunavukkarasu <[email protected]> >> wrote: >> >>> Yah Imesh, Grouping functionality has been tested in the pre-alpha and >>> most of the features were working fine. We will need to fix some other edge >>> cases.. >>> >>> Thanks, >>> Reka >>> >>> On Wed, Feb 18, 2015 at 7:15 PM, Imesh Gunaratne <[email protected]> >>> wrote: >>> >>>> I think I found the root cause of the most of the grouping >>>> functionality issues after debugging it for nearly a day. >>>> >>>> The problem seems to be with the usage of aliases and ids. AFAIK >>>> grouping functionality worked without a problem in pre-alpha there after it >>>> broke when we did some fixes related to aliases. >>>> >>>> I'm now review this and doing a fix. >>>> >>>> On Tue, Feb 17, 2015 at 6:36 PM, Imesh Gunaratne <[email protected]> >>>> wrote: >>>> >>>>> The above issue has occurred because of the time it takes to SM to >>>>> receive the application created event. Now I have fixed this my making a >>>>> service call from SM to AS to find cluster id of a given application, >>>>> cartridge alias rather than relying on the application events. >>>>> >>>>> This fix is now available in master branch. >>>>> >>>>> On Sun, Feb 15, 2015 at 5:15 PM, Imesh Gunaratne <[email protected]> >>>>> wrote: >>>>> >>>>>> I think I found the reason for not publishing Artifact Updated event. >>>>>> It looks like the Mock IaaS is responding fast and SM is receiving the >>>>>> Instance Started event before receiving the Application Created event. >>>>>> I'm >>>>>> now fixing this. >>>>>> >>>>>> Thanks >>>>>> >>>>>> On Sun, Feb 15, 2015 at 2:56 PM, Imesh Gunaratne <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> Hi Devs, >>>>>>> >>>>>>> I just did a quick test to verify grouping functionality with sample >>>>>>> applications and following is the current status: >>>>>>> >>>>>>> ApplicationStatusNotescomplex-appNot Activatingcomplex-app-with-lbNot >>>>>>> Activatingdependent-scaling/sample-cartridgesActivates but found >>>>>>> few errorsArtifact update event is not published >>>>>>> dependent-scaling/sample-groupsNot Activatinggroup-cartridgesNot >>>>>>> ActivatingArtifact update event is not publishedgroup-scalingNot >>>>>>> ActivatingArtifact update event is not publishedgroup-scaling-v1Not >>>>>>> Activatingmore-complex-appNot ActivatingArtifact update event is >>>>>>> not publishednested-groupNot ActivatingArtifact update event is not >>>>>>> publishedsingle-cartridgeOKsingle-group-group-scalingOK >>>>>>> single-group-v1Not ActivatingArtifact update event is not published >>>>>>> single-group-v2Not ActivatingArtifact update event is not published >>>>>>> single-group-v3Not ActivatingApplication deployment stops at some >>>>>>> point >>>>>>> We have 14 sample applications now and only 2 of them get activated >>>>>>> properly. Please find more details in the below spread-sheet: >>>>>>> >>>>>>> Sample Applications - Current Status.xlsx >>>>>>> <https://docs.google.com/spreadsheets/d/1GBIQuitW4w8G_zXFArgaUBo8P5p0KHql7Aef-XNqg3o/edit?usp=drive_web> >>>>>>> >>>>>>> The above test was done with Mock IaaS and I see an issue in ADC >>>>>>> where it cannot find the application while trying to publish the >>>>>>> Artifact >>>>>>> Updated event once Instance Started is received. I'm now investigating >>>>>>> this. >>>>>>> >>>>>>> Thanks >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Imesh Gunaratne >>>>>>> >>>>>>> Technical Lead, WSO2 >>>>>>> Committer & PMC Member, Apache Stratos >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Imesh Gunaratne >>>>>> >>>>>> Technical Lead, WSO2 >>>>>> Committer & PMC Member, Apache Stratos >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Imesh Gunaratne >>>>> >>>>> Technical Lead, WSO2 >>>>> Committer & PMC Member, Apache Stratos >>>>> >>>> >>>> >>>> >>>> -- >>>> Imesh Gunaratne >>>> >>>> Technical Lead, WSO2 >>>> Committer & PMC Member, Apache Stratos >>>> >>> >>> >>> >>> -- >>> Reka Thirunavukkarasu >>> Senior Software Engineer, >>> WSO2, Inc.:http://wso2.com, >>> Mobile: +94776442007 >>> >>> >>> >> >> >> -- >> Imesh Gunaratne >> >> Technical Lead, WSO2 >> Committer & PMC Member, Apache Stratos >> > > > > -- > Reka Thirunavukkarasu > Senior Software Engineer, > WSO2, Inc.:http://wso2.com, > Mobile: +94776442007 > > > -- Imesh Gunaratne Technical Lead, WSO2 Committer & PMC Member, Apache Stratos
